generated from aws-ia/terraform-repo-template
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Velero backup_location
to allow s3:actions
with or without bucket prefix declaration.
#145
Merged
+45
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor
locals
and IAM Policyresources
to allows3:actions
on Buckets with or without prefix.The existing configuration creates an IAM Policy to allow
s3:actions
in the declared S3 ARN with a Bucket Prefix, however if the customer provides the ARN without a Bucket prefix, the Policy will not allow thes3:actions
in the bucket objects or folders.More
pre-commit run -a
with this PRFor Moderators
Additional Notes
Example with Bucket Prefix
tests/complete
# velero backup-location get NAME PROVIDER BUCKET/PREFIX PHASE LAST VALIDATED ACCESS MODE DEFAULT default aws dev/dev Unavailable 2023-04-27 11:52:09 -0400 EDT ReadWrite
Example with a Bucket provided by an S3 Module
module.velero_backup_s3_bucket
without Bucket Prefixtests/complete
# aws s3 ls 2023-04-27 12:08:07 complete-20230427160804638700000001
# velero backup-location get NAME PROVIDER BUCKET/PREFIX PHASE LAST VALIDATED ACCESS MODE DEFAULT default aws complete-20230427160804638700000001 Unavailable 2023-04-27 12:08:40 -0400 EDT ReadWrite